Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authenticatorMakeCredential operation credential filtering #650

Closed
jovasco opened this issue Oct 16, 2017 · 5 comments
Closed

authenticatorMakeCredential operation credential filtering #650

jovasco opened this issue Oct 16, 2017 · 5 comments
Assignees
@jovasco
Labels
stat:pr-open type:editorial type:technical
Milestone
WD-07

Comments

@jovasco
Copy link
Contributor

jovasco commented Oct 16, 2017 •
edited by equalsJeffH
Loading

  1. Check if a credential matching an item of excludeCredentialDescriptorList is present on this authenticator. If so, return an error code equivalent to "NotAllowedError" and terminate the operation.

This should explicitly mention that the the item must be checked to match the provided RP ID.

See PR #651
@equalsJeffH equalsJeffH added this to the WD-07 milestone Oct 18, 2017
@equalsJeffH equalsJeffH self-assigned this Oct 18, 2017
This was referenced Oct 18, 2017
Merged
Closed
@equalsJeffH
Copy link
Contributor

equalsJeffH commented Oct 18, 2017 •
edited
Loading

updated: I had written:

This seems like a correct update to that step to me -- others?
If so, I'll fix this in PR #498 and we can close PR #651.

have decided to not address this in PR #498.

@nadalin
Copy link
Contributor

nadalin commented Oct 23, 2017

@jovasco This seems just like a editorial issue.

@equalsJeffH
Copy link
Contributor

@nadalin, this is technical.

@equalsJeffH
Copy link
Contributor

am assigning to @jovasco since he authored PR #651 intended to resolve this, and I ended up not addressing it in PR #498.

@equalsJeffH equalsJeffH assigned jovasco and unassigned equalsJeffH Oct 23, 2017
@jcjones
Copy link
Contributor

jcjones commented Nov 3, 2017

Closed in #651.

@jcjones jcjones closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jovasco jovasco

Labels
stat:pr-open type:editorial type:technical
Projects
None yet
Milestone
WD-07
Development

No branches or pull requests
4 participants
@equalsJeffH @jcjones @nadalin @jovasco