Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove alg argument lists in Abort Operation section #707

Closed
equalsJeffH opened this issue Dec 5, 2017 · 2 comments
Closed

remove alg argument lists in Abort Operation section #707

equalsJeffH opened this issue Dec 5, 2017 · 2 comments

Comments

@equalsJeffH
Copy link
Contributor

Our convention of mostly always listing the argument list of our [[Create]](origin, options, sameOriginWithAncestors) and [[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors) internal methods unfortunately renders the "Abort operations with AbortSignal" section almost unreadable.

This is my overly-zealous fault. I propose to rectify it by using the form-with-arglist for each of [[Create]] and [[DiscoverFromExternalSource]]'s first occurances in that section and then abbreviate them to only [[Create]] and [[DiscoverFromExternalSource]] in further occurances.

WDYT?

@equalsJeffH equalsJeffH added this to the CR milestone Dec 5, 2017
@equalsJeffH equalsJeffH self-assigned this Dec 5, 2017
@emlun
Copy link
Member

emlun commented Dec 8, 2017

Sounds good to me. I wouldn't be against dropping the parameter lists from most or all references to the methods - they each have only one parameter signature, right? - but I don't know about the broader conventions on this.

@equalsJeffH
Copy link
Contributor Author

Ok, I looked into this and given the way bikeshed links-up IDL and all it seems that absent some specialized tweaking of said linking, it's just the way it is, and not worth a bunch of time trying to figure it out. so I suggest I close this wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants