Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the Token Binding ID a base64url encoded DOMString rather than an ArrayBuffer? #807

Closed
selfissued opened this issue Feb 16, 2018 · 7 comments

Comments

@selfissued
Copy link
Contributor

Given we're changing the Token Binding representation anyway, is there a reason that the Token Binding ID representation needs to stay a base64url encoded DOMString rather than be changed to an ArrayBuffer containing the raw Token Binding ID bytes?

@selfissued selfissued added this to the CR milestone Feb 16, 2018
@arnar
Copy link
Contributor

arnar commented Feb 17, 2018

Are you suggesting CollectedClientData be implicitly converted to JSON, taking care of e.g. ArrayBuffer?

In #803 you linked to this, but I'm having some trouble finding how ArrayBuffers are converted to JSON.

@arnar
Copy link
Contributor

arnar commented Feb 17, 2018

(cc @kpaulh)

@selfissued
Copy link
Contributor Author

That's right. If this is converted to JSON, then it makes sense to leave it as is. I wanted to at least ask the question.

@akshayku akshayku modified the milestones: CR, Last Working Draft Feb 18, 2018
@agl
Copy link
Contributor

agl commented Feb 21, 2018

(Just from the call. I opined that this needs to be a string because the CollectedClientData is serialised as JSON and thus cannot contain ArrayBuffers. We're going to ask Kim to weigh in.)

@kpaulh
Copy link
Contributor

kpaulh commented Feb 21, 2018

I agree with @agl; ArrayBuffers would cause problems for serialization. Also, we don't pack CollectedClientData in Blink in our implementation, so ArrayBuffers would be really annoying to deal with, if possible at all.

@agl
Copy link
Contributor

agl commented Feb 21, 2018

(I think this is resolved and can be closed.)

@selfissued
Copy link
Contributor Author

Closing with no action, based on @kpaulh 's feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants