Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationExtensions typedef name is confusing; also there are issues with its description #471

Closed
equalsJeffH opened this issue May 23, 2017 · 4 comments

Comments

@equalsJeffH
Copy link
Contributor

equalsJeffH commented May 23, 2017

see 4.7. Authentication Extensions (typedef AuthenticationExtensions)

the name "AuthenticationExtensions" is confusing (to me at least) because "extensions" may be requested in both [[Create]](options) {#createCredential} and [[DiscoverFromExternalSource]](options) {#getAssertion} methods, and there are two extension subtypes: "authenticator extensions" and "client extensions".

Additionally, this same typedef is used to return extension results within the PublicKeyCredential object.

I suggest we rename this object "WebAuthenticationExtensionData". then having subtypes denoted as "authenticator extensions" and "client extensions" does not seem odd, because they are just abbreviated names for e.g. "authenticator web authentication extension" and "client web authentication extension".

I note that we do use the term "web authentication" in a few key manners, and it seems to me this ought to be one of them.

Additionally, I suggest we rename §8 WebAuthn Extensions to be "§8 Web Authentication Extensions".

I can address this as part of finishing PR #464.

@equalsJeffH
Copy link
Contributor Author

the description issues are that the description needs to be updated to reflect that an WebAuthenticationExtensionData (nee AuthenticationExtension) instance is actually an ordered map.

@equalsJeffH
Copy link
Contributor Author

actually, will do this in another PR, like a sweep-up-all-the-outstanding-extensions-stuff PR. #464 is complex enough.

@nadalin nadalin modified the milestones: WD-07, WD-06 Jul 5, 2017
@jcjones
Copy link
Contributor

jcjones commented Oct 11, 2017

The under-specified behaviors are also an issue for #626

@jcjones
Copy link
Contributor

jcjones commented Oct 11, 2017

We've agreed that the existing name matches up with the other Authenticator... names in our WebIDL, and we're going to stick with it.

The second half of this issue is addressed in #626, so closing this and we're keeping AuthenticationExtensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment