-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebCodecs VideoFrame metadata registry] Introduce VideoFrame metadata #559
Conversation
@sandersdan FYI. |
ba3867f
to
48cfad4
Compare
We just discussed this among the Chrome media team, and it turns out we're okay leaving out the The reasoning here is that if we're not storing metadata also on chunks, and we're not copying metadata between chunks and frames, then users will have to map their own metadata to frames separately anyway (presumably by timestamp). Therefore the |
FWIW, one use case I can see is the AR/VR use case where metadata is retrieved by a worker through WebRTC encoded transform, then metadata is passing through decoder to MediaStreamTrack VideoFrames. In that case there might be two contexts so it seems nice to attach application metadata to VideoFrames directly. That said, I am more than happy to leave this to another day/another PR. |
48cfad4
to
e51d241
Compare
I removed user metadata from this PR. |
Fix some additional nits.
One potential downsides of using a VideoFrameMetadata interface is that we would probably anyway need a VideoFrameMetadataInit dictionary. |
As a side note, VideoFrameMetadata name (even though dictionary names are not that important) conflicts with https://wicg.github.io/video-rvfc/#dictdef-videoframemetadata. |
I'd be fine with renaming the rVFC Albeit verbose, rVFC |
Sounds good, dictionary names are not exposed to JS so verbosity is not a big issue anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach LGTM. The editors are more qualified to review the text of the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still lgtm; thanks @youennf -- though there is some PR build error:
FATAL ERROR: Couldn't find 'webcodecs-video-frame-metadata-registry' in bibliography data.
I think it's fine to be empty. I'll raise another PR for the remaining procedural bits. We can probably also drop this item from the Media WG meeting agenda for tomorrow. |
Yes. |
@aboba, can you review again the PR and approve it if you think this is fine? |
Bump on this one before submitting though. |
@tidoust, can you shed some light on the issue @dalecurtis is mentioning above? |
The entry is needed until the registry gets published and can be added to official databases of specs.
I pushed an update to add the entry to the local biblio. The entry can be removed when the registry document comes to existence and gets added to official biblio databases. |
Great, looks like we're all good here. Thanks @youennf! |
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3b714ac Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Preview | Diff