Skip to content

Commit

Permalink
[Shadow DOM] [Bug 27775] Update Element.getDestinationInsertionPoints…
Browse files Browse the repository at this point in the history 
…(), using the 'an unclosed node of' relation'.
  • Loading branch information
@hayatoito
hayatoito committed May 8, 2015
1 parent 503e27c commit 644a0fa
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions spec/shadow/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1316,8 +1316,10 @@ <h3>Extensions to <code>Element</code> Interface</h3>
</dd>

<dt>NodeList getDestinationInsertionPoints()</dt>
<dd>When invoked, the method <strong>must</strong> return a <a>static</a> <a><code>NodeList</code></a> consisting of <a title="insertion point">insertion points</a> in the <a>destination insertion points</a> of the <a>context object</a>, excluding an <a>insertion point</a> which participates in a <a>closed</a> shadow tree.</dd>

<dd>
When invoked, the method <strong>must</strong> return a <a>static</a> <a><code>NodeList</code></a> consisting of <a title="insertion point">insertion points</a> in the <a>destination insertion points</a> of the <a>context object</a>.
The <code>NodeList</code> <strong>must not</strong> contain an <a>insertion point</a> that is not an <a>unclosed node</a> of the <a>context object</a>.

This comment has been minimized.

Sign in to view

Copy link
@annevk

annevk May 8, 2015

Collaborator

I don't like that this defines the return values in terms of a negative. Shouldn't it roughly say "return unclosed insertion points"?

This comment has been minimized.

Sign in to view

Copy link
@hayatoito

hayatoito May 8, 2015

Author Contributor

Agree. However "unclosed" can't be used in standalone because it's relationship between two nodes.

Do you have any idea to simplify this?
Does "unclosed insertion points of the context object in the destination insertion points of the context object" sound good?

This comment has been minimized.

Sign in to view

Copy link
@annevk

annevk May 8, 2015

Collaborator

Yeah, that seems better. Or maybe we should have "light tree", "shadow tree", "composed tree", and "unclosed tree" and then each time we just specify the tree we're talking about. And for a given tree we can then use the definitions that DOM already defines, such as parent/child/ancestor etc.
</dd>
<dt>readonly attribute ShadowRoot? shadowRoot</dt>
<dd>
<p>Represents the <a>shadow root</a> that <a>context object</a> <a>hosts</a>.</p>
Expand Down

0 comments on commit 644a0fa

Please sign in to comment.