Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow DOM and "insertion steps" / "removing steps" #438

Closed
annevk opened this issue Mar 11, 2016 · 6 comments
Closed

Shadow DOM and "insertion steps" / "removing steps" #438

annevk opened this issue Mar 11, 2016 · 6 comments

Comments

@annevk
Copy link
Collaborator

annevk commented Mar 11, 2016

The Shadow DOM specification needs to "monkey patch" DOM Standard's "insert" and "remove" algorithms to account for shadow trees.

If nodes in shadow trees are never notified they have been inserted or removed, there are no hooks for other standards to define how they should behave there.

@annevk
Copy link
Collaborator Author

annevk commented Mar 16, 2016

I have done this now in the DOM Standard directly. See:

Feedback appreciated.

@hayatoito
Copy link
Contributor

Looks good. Thank you.

BTW, I am totally okay to have host-including ancestor, shadow-root-including descendant, shadow-host-including inclusive ancestor and so on, as a replacement of composed-xxx.

Do you have any feeling when you used these terms in DOM Standard? If you felt good, I think that's a good news and we can use these terminologies.

@annevk
Copy link
Collaborator Author

annevk commented Mar 17, 2016

I think one problem is that I have used "shadow-root-including" and not "shadow-host-including". Maybe I should just say "shadow-including". That might make the most sense.

annevk added a commit to whatwg/dom that referenced this issue Mar 17, 2016
@annevk
Copy link
Collaborator Author

annevk commented Mar 17, 2016

Thanks for the review. If someone still finds the terms unacceptable please raise an issue.

@annevk annevk closed this as completed Mar 17, 2016
@hayatoito
Copy link
Contributor

Either is okay to me. I just thought you tried to make them more explicit.

  • shadow-host-including ancestor
  • shadow-root-including descendant

I thought this pair is very intuitive.

@annevk
Copy link
Collaborator Author

annevk commented Mar 17, 2016

I see. Okay, if this comes up again I'll switch back to the longer prefixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants