Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: create an element's "new element" step #463

Closed
annevk opened this issue Mar 29, 2016 · 4 comments
Closed

Editorial: create an element's "new element" step #463

annevk opened this issue Mar 29, 2016 · 4 comments

Comments

@annevk
Copy link
Collaborator

annevk commented Mar 29, 2016

This algorithm has 4 fairly equivalent steps to create a new element. Is there a way to do the top-level conditionals differently so this can be a shared step? It seems that might be a little cleaner.

@domenic
Copy link
Collaborator

domenic commented Mar 29, 2016

I kind of doubt it, because the timing needs to vary for each. Happy to take a concrete suggestion or PR, but I think this is fine as-is personally.

@domenic domenic added the v1 label Mar 29, 2016
@annevk
Copy link
Collaborator Author

annevk commented Mar 29, 2016

It seems reasonably doable. Would have to think about it a little bit, but if you know it's not the 4.1 substeps (through a conditional that seems like it can be created) and you make sure "element interface" returns HTMLElement to handle the 4.2 substeps case you can allocate an element early (and an otherwise statement to handle the constructor dance).

Then the following steps can handle details around is="" attributes and whether or not to queue something.

@domenic
Copy link
Collaborator

domenic commented Apr 4, 2016

The algorithm has changed a decent bit at this point. Still not a fan of this kind of change but you're welcome to make a PR. Untagging v1 to get it off my hotlist.

@domenic domenic removed the v1 label Apr 4, 2016
@annevk
Copy link
Collaborator Author

annevk commented Apr 16, 2016

Mu.

@annevk annevk closed this as completed Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants