Fix typo in '2.1.1 Creating a custom tag' #446
Conversation
| @@ -176,7 +176,7 @@ <h4 id="custom-elements-custom-tag-example">Creating a custom tag</h4> | |||
| <p>We then need to use this class to define the element:</p> | |||
|
|
|||
| <pre class="highlight"> | |||
| document.defineElement("flag-icon", FlagIcon);</pre> | |||
| document.registerElement("flag-icon", FlagIcon);</pre> | |||
There was a problem hiding this comment.
This isn't right. We should be using window.customElements.define instead.
There was a problem hiding this comment.
Agree. But if you check window.customElements in browser then it isn't define yet. But, document.registerElement at least is present in Firefox and Chrome. For the shake of the example let's consider use registerElement. After all by using registerElement the example will work in some way.
There was a problem hiding this comment.
The example should reflect the specification, not the current implementations in browsers.
There was a problem hiding this comment.
Yes, you're right! This interface 2.4 The CustomElementsRegistry interface should be used.
Anyway. Will be great if other developers will read an example that works. The introduction section is non-normative after all. So, today we can read an example that works and allows us to understand the meaning of custom components.
According to #431 the example given in the documentation should use document.registerElement instead of document.defineElement