Copy edits for all remaining parts #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
reviewed
Nov 2, 2017
|
|
||
| As suggested by others in the past discussions, we propose to use nested templates for these cases: | ||
| As suggested by others in past discussions,fo these cases we propose to use nested templates: |
rniwa
reviewed
Nov 2, 2017
| @@ -338,7 +338,7 @@ To make this process more streamlined, we propose treating inner template elemen | |||
| }; | |||
| ``` | |||
|
|
|||
| With this interface, the template process callback that implements foreach and other kinds of looping constructs could simply call `replace` with newly constructed elements as follows: | |||
| With this interface, the template process callback that implements a *foreach* and other kinds of looping constructs could simply be called `replace` with newly constructed elements, as follows: | |||
There was a problem hiding this comment.
The original sentence was correct. "The template process callback ~ could simply call replace with newly constructed elements,".
rniwa
reviewed
Nov 2, 2017
|
|
||
| We like the idea of supporting very basic control flow such as `if` and `foreach` in the default template process callback but we don't think it's a show stopper if the default template process callback didn't support them in the initial cut. | ||
|
|
||
| We like the idea of supporting very a basic control flow such as `if` and `foreach` in the default template process callback, but we don't think it'd be a show stopper if the default template process callback didn't support them in the initial cut. |
There was a problem hiding this comment.
This should have said "supporting very basic control flow statements".
rniwa
reviewed
Nov 2, 2017
| 5. For every [descendant](https://dom.spec.whatwg.org/#concept-tree-descendant) node *currentNode* of *instance* in [tree order](https://dom.spec.whatwg.org/#concept-tree-order), run these steps: | ||
| 1. If *currentNode* is a [`template` element](https://html.spec.whatwg.org/multipage/scripting.html#the-template-element): | ||
| 1. Run the concept to _adjust single node case_ with *currentNode*. | ||
| 2. Let *nodeValueSetter* be a new instance of the _node value setter_ with *currentNode*, the [previous sibling](https://dom.spec.whatwg.org/#concept-tree-next-sibling) of *currentNode*, the [next sibling](https://dom.spec.whatwg.org/#concept-tree-next-sibling) of *currentNode*, an empty _previous replacement nodes_, _fully templatized_ flag set to the result of running the concept to _determine full templatizability_ with *currentNode*, and an empty _node template part list_. |
There was a problem hiding this comment.
I'm using _ to only refer to variable names. So please don't italicize concepts defined elsewhere.
rniwa
reviewed
Nov 2, 2017
| 5. [Remove](https://dom.spec.whatwg.org/#concept-node-remove) *currentNode* from the *currentNode*'s [parent](https://dom.spec.whatwg.org/#concept-tree-parent). | ||
| 6. Run the concept to _apply node template part list_ with *nodeValueSetter*. | ||
| 5. For every [descendant](https://dom.spec.whatwg.org/#concept-tree-descendant) node *currentNode* of *instance* in [tree order](https://dom.spec.whatwg.org/#concept-tree-order), run these steps: | ||
| 1. If *currentNode* is a [`template` element](https://html.spec.whatwg.org/multipage/scripting.html#the-template-element): |
There was a problem hiding this comment.
I'd like to keep using 4-space indentations. Please revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.