Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "serialize as a remote value" may need to be fallible #328

Open
jugglinmike opened this issue Nov 21, 2022 · 0 comments
Open

The "serialize as a remote value" may need to be fallible #328

jugglinmike opened this issue Nov 21, 2022 · 0 comments
Labels
bug Something isn't working remote value Serialization and Deserialization of Remote Values

Comments

@jugglinmike
Copy link
Contributor

Based on the use of "serialize as a remote value" in the script.evaluate command, it appears that the serialization algorithm has to anticipate abrupt completions. At the moment, however, it is defined as an infallible operation.

For instance, the following script produces a value which presents as a RegExp but whose "flags" property is "poisoned":

Object.defineProperty(/./, 'flags', { get() { throw 0; } });

As currently written, "serialize as a remote value" does not account for this possibility, and it uses the completion record returned by ECMAScript's Get instead of the completion record's [[Value]] field.

@whimboo whimboo added bug Something isn't working remote value Serialization and Deserialization of Remote Values labels Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working remote value Serialization and Deserialization of Remote Values
Projects
None yet
Development

No branches or pull requests

2 participants