Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command response: "value" or "result"? #58

Closed
foolip opened this issue Oct 1, 2020 · 2 comments
Closed

Command response: "value" or "result"? #58

foolip opened this issue Oct 1, 2020 · 2 comments
Labels

Comments

@foolip
Copy link
Member

foolip commented Oct 1, 2020

In #50, the CommandResult CDDL definition was added, with "value" as the property to hold the result of a successful command. I noticed this and suggested changing it in #56 (comment), but moving to a separate issue.

https://www.jsonrpc.org/specification uses "result" and in #14 (comment) and #14 (comment) I provided samples of Chrome and Safari's devtools/inspector protocols showing that they also use "result".

Although it will not be possible to use existing libraries for JSON-RPC or existing devtools/inspector protocols with WebDriver BiDi, I would like to match existing protocols where it is of no consequence and only a matter of picking a name. So I am suggesting that we use "result".

@shs96c
Copy link

shs96c commented Oct 6, 2020

The discussion in #14 suggests that result is the appropriate response to use. This is inline with existing browser debugging protocols, and with JSON-RPC.

@whimboo
Copy link
Contributor

whimboo commented Sep 30, 2022

And this was done as part of PR #62 quite a while ago.

@whimboo whimboo closed this as completed Sep 30, 2022
@whimboo whimboo added the cddl label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants