Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify if "browsingContext.captureScreenshot" command with "origin=viewport" should take into account scrollbar dimensions #592

Open
lutien opened this issue Nov 6, 2023 · 1 comment
Labels
browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group

Comments

@lutien
Copy link
Contributor

lutien commented Nov 6, 2023

At the moment, it's not fully clear in the get the origin rectangle algorithm for the case of origin=viewport if we should take into account scrollbar dimensions when calculating the viewport width and height. The text says, that we should use VisualViewport width and height (which would mean not including scrollbar), but the width and height are linked to DOMRect (which would mean including scrollbar).

The WebDriver Classic spec refers to DOMRect.
Where CDP, from what I've understood, seems to default to VisualViewport.

@OrKoN
Copy link
Contributor

OrKoN commented Mar 25, 2024

I think it probably makes sense to include the scrollbar(s) here. cc @sadym-chromium @Lightning00Blade wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

3 participants