Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having only "alwaysMatch" but no "firstMatch" capabilities doesn't work as defined #1530

Open
foolip opened this issue Jun 4, 2020 · 0 comments

Comments

@foolip
Copy link
Member

foolip commented Jun 4, 2020

It looks like there's a bug in https://w3c.github.io/webdriver/#dfn-capabilities-processing.

The "alwaysMatch" capabilities are extracted into a required capabilities variable, while the "firstMatch" capabilities array are extracted into a all first match capabilities variable. That list is turned into a validated first match capabilities.

Then comes the bug.

The merged capabilities is constructed from validated first match capabilities, but if that's an empty list, merged capabilities will also be empty and we will reach "Return success with data null."

That should cause https://w3c.github.io/webdriver/#new-session to fail at the following step, "If capabilities’s is null, return error with error code session not created.", but that's not what should happen.

Suggested fix: If merged capabilities is an empty list, append required capabilities to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant