Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Timeouts should update existing timeouts, not overwrite them all #1596

Open
shs96c opened this issue Jun 8, 2021 · 0 comments
Open

Set Timeouts should update existing timeouts, not overwrite them all #1596

shs96c opened this issue Jun 8, 2021 · 0 comments

Comments

@shs96c
Copy link
Contributor

shs96c commented Jun 8, 2021

It is unclear when reading the spec if Set Timeouts should reset all timeouts to their default values and only update a single value if called with only one value (eg. script), or whether it should only alter the given value.

All existing implementations choose the latter implementation, which is also the one that intuitively feels correct. I suggest we amend the spec to make this clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants