Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Screenshot command missing "Handle any user prompts" step #1678

Open
patrickangle opened this issue Aug 23, 2022 · 0 comments
Open

Take Screenshot command missing "Handle any user prompts" step #1678

patrickangle opened this issue Aug 23, 2022 · 0 comments

Comments

@patrickangle
Copy link

https://w3c.github.io/webdriver/#take-screenshot

It appears that the spec is missing a step for the Take Screenshot command to handle user prompts after ensuring there is a browsing context and before taking the screenshot (between steps 1 and 2). There are WPT tests that rely on user prompts being handled (https://wpt.fyi/results/webdriver/tests/take_screenshot/user_prompts.py), so it seems like an accidental omission.

It appears Chrome, Edge, and Firefox already handle these prompts and Safari is the only browser not doing so anyways (we also have another bug preventing us from handling prompts in any test, but we don't even attempt to handle prompts for the take screenshot command currently).

Should the spec be updated, or am I missing something here? If there are no objections I can submit a PR to add the step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant