Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error for annonated inner types of generic types #71

Closed
tobie opened this issue Jun 15, 2017 · 4 comments
Closed

Parsing error for annonated inner types of generic types #71

tobie opened this issue Jun 15, 2017 · 4 comments

Comments

@tobie
Copy link
Member

tobie commented Jun 15, 2017

Parsing the below throws the following: Error parsing generic type Promise.

interface Foo {
  Promise<[XAttr] long> doStuff();
};

This should be supported per spec.

@marcoscaceres
Copy link
Member

@saschanaz, can you take a look?

@saschanaz
Copy link
Member

Yup, sorry for the delay, I'll take a look.

@saschanaz
Copy link
Member

It seems the spec currently defines Promise types as:

PromiseType ::
    Promise < ReturnType >

and thus does not support annotated types. sequence<[XAttr] long> doStuff(); should be supported, however.

@tobie
Copy link
Member Author

tobie commented Jul 1, 2017

You're absolutely right. Promises don't take annotated types, but sequences do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants