Introduce the PaymentAppResponseData dictionary #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlongley
reviewed
Jan 12, 2017
| The <a>payment app response data</a> is conveyed using the following | ||
| dictionary: | ||
| <pre class="idl"> | ||
| dictionary PaymentAppResponseData { |
There was a problem hiding this comment.
Should the name be simply PaymentAppResponse instead? Does appending Data to it add anything?
There was a problem hiding this comment.
I suppose that would be just as good a name, but then I would insist that we also change PaymentAppRequestData to PaymentAppRequest
There was a problem hiding this comment.
I don't feel strongly about "Data." (I do want to avoid confusion with "Payment Request" and "Payment Response")
added 2 commits
January 16, 2017 14:50
... and try to correct surrounding text that refers to this name.
This is used instead of PaymentResponse to pass data back from the payment app to the user agent.
tommythorsen
force-pushed
the
responsedata
branch
from
f8b0268
to
1ebbb13
Compare
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Feb 1, 2017
Recently, the name was changed in the spec[1][2][3]. [1] w3c/payment-handler#84 [2] https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest [3] https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentrequestevent BUG=661608 Review-Url: https://codereview.chromium.org/2665583002 Cr-Commit-Position: refs/heads/master@{#447236}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used instead of PaymentResponse to pass data back from the
payment app to the user agent.