Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sepamail WebIDL syntax and algorithms #219

Closed
rsolomakhin opened this issue Mar 20, 2017 · 4 comments
Closed

Sepamail WebIDL syntax and algorithms #219

rsolomakhin opened this issue Mar 20, 2017 · 4 comments

Comments

@rsolomakhin
Copy link
Collaborator

rsolomakhin commented Mar 20, 2017

I suggest the following changes in in sepamail proposal:

  1. The type of supportedNetworks should change from sequence to sequence<DOMString>.
  2. The type of supportedTypes should change from sequence to sequence<BasicSepamailType>.
  3. The name of SelectedNetwork should change to selectedNetwork.
  4. The name of SelectedType should change to selectedType.

Also, please add some algorithms to process BasicSepamailRequest in the browser. At the very least, please specify what should happen if supportedNetworks or supportedTypes is an empty list. What should happen if supportedNetworks contains empty or duplicate strings. (I suggest throwing TypeError in all those cases.)

@marcoscaceres
Copy link
Member

sepamailIdentifier should just be "id"

@ianbjacobs
Copy link
Contributor

I believe Cyril has integrated comments:
https://w3c.github.io/webpayments/proposals/sepamail.html

(Cyril has asked Rouslan to verify.)

@rsolomakhin
Copy link
Collaborator Author

Looks good, thank you.

@ianbjacobs
Copy link
Contributor

We have not worked on the sepamail proposal for a long time so closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants