Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

width/height metadata on incoming streams #138

Open
fippo opened this issue Jul 18, 2022 · 1 comment
Open

width/height metadata on incoming streams #138

fippo opened this issue Jul 18, 2022 · 1 comment

Comments

@fippo
Copy link
Collaborator

fippo commented Jul 18, 2022

The video frame metadata come with width and height:
https://w3c.github.io/webrtc-encoded-transform/#dom-rtcencodedvideoframemetadata-width

For outgoing streams this makes some sense since it is easily known (but it isn't clear to me what the use-case is), for incoming streams this requires pre-parsing the VPx payload descriptor, the H264 SPS (or PPS?) and the AV1 sequence header OBU.

Is anyone relying on this behavior? Note that it already doesn't work for AV1 so the values are 0/0 and I heard a "we would like to move away from parsing bitstreams" here that I agree with.

While I don't think we can change this to be optional depending on the direction, we can at least consistently set width/height to 0 on incoming streams.

@alvestrand
Copy link
Contributor

These are dictionary members without "required" on them, so omitting them is completely consistent with syntax.
I would much prefer "missing member" over 0/0 as "there's nothing here to see" indication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants