Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promises in [[pendingKeyFrameTasks]] are not settled when the encoder is destroyed, or a simulcast encoding goes away #184

Open
docfaraday opened this issue Jun 2, 2023 · 1 comment
Open

Promises in [[pendingKeyFrameTasks]] are not settled when the encoder is destroyed, or a simulcast encoding goes away #184

docfaraday opened this issue Jun 2, 2023 · 1 comment

Comments

@docfaraday
Copy link

There does not appear to be any language in the spec saying what to do with tasks in [[pendingKeyFrameTasks]] when an encoder or stream is destroyed. Are these intended to never settle? Or should we be rejecting the leftover promises?
@youennf
Copy link
Collaborator

youennf commented Jul 5, 2023

As per spec, they would never settle until a key frame is actually generated.
Isn't it the desired behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@docfaraday @youennf