Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RTP Timestamp to Metadata and rename #203

Closed
tonyherre opened this issue Sep 6, 2023 · 4 comments · Fixed by #204
Closed

Move RTP Timestamp to Metadata and rename #203

tonyherre opened this issue Sep 6, 2023 · 4 comments · Fixed by #204

Comments

@tonyherre
Copy link
Contributor

Currently both RTCEncodedAudioFrame and RTCEncodedVideoFrame have a timestamp field directly on the frame defined as the RTP timestamp, and a timestamp in their Metadata dict defined as the Presentation timestamp (to match WebCodecs). This is quite a confusing situation.

As discussed during the April Interim and on #173, it makes sense to move the RTP timestamp to the metadata and rename it rtpTimestamp.

@fippo
Copy link
Collaborator

fippo commented Sep 6, 2023

we had #169 for that? Either way, the PR fixes both.

@tonyherre
Copy link
Contributor Author

I thought the same re #169 , but re-reading it before filing the PR it seems to be suggesting that we should try to map the existing timestamp field to the WebCodecs encoded frame timestamp by changing to long long etc.
AIUI, the path we settled on in #173 was a little different - adding the new long long Metadata.timestamp field holding the presentation time, so matching the WebCodecs field, and rename the old unsigned long timestamp to make it explicit that it's holding the RTP timestamp.

I'll add a comment over there too.

@tonyherre
Copy link
Contributor Author

Oh, hmm, maybe I misunderstood #169 after all and this is the same?

@fippo
Copy link
Collaborator

fippo commented Sep 7, 2023

We agree on what needs to be done - thank for pushing it! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants