Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify upper limit to playoutDelayHint #11

Closed
henbos opened this issue Oct 29, 2019 · 3 comments · Fixed by #22
Closed

Specify upper limit to playoutDelayHint #11

henbos opened this issue Oct 29, 2019 · 3 comments · Fixed by #22

Comments

@henbos
Copy link
Collaborator

henbos commented Oct 29, 2019

Per discussions at #8, it would be good for specificity, interoperability and testability if we had an explicit upper limit to the hint. We don't want this API to be a way to buffer data for 10 minutes for example.

@henbos
Copy link
Collaborator Author

henbos commented Nov 25, 2019

@kuddai said that current implementation in Chrome has "4 seconds for audio buffer and 10 seconds for video buffer"

How about we make the upper limit 4 seconds for both audio or video?

@kuddai
Copy link
Contributor

kuddai commented Nov 25, 2019

Starting lower is the safer because if we ever want to increase the maximum then it won't break existing implementations that relying on that behavior.

What error type would be appropriate if user sets value beyond maximum allowed one?

@jan-ivar what do you think about 4 seconds as the maximum value?

@henbos
Copy link
Collaborator Author

henbos commented Nov 25, 2019

In webrtc-pc we use RangeError and InvalidModificationError. I guess if it's a hardcoded limit, RangeError makes sense, unless there are historical reasons for preferring one exception over another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants