Request keyframe via setParameters #167

fippo · 2023-05-12T18:33:21Z

Fixes #158

use setParameters() which is often used in situations that may yield a key frame such as resizing the video.

The semantic of that flag is the same as the RTCP FIR semantics from
https://www.rfc-editor.org/rfc/rfc5104#section-3.5.1

Preview | Diff

use setParameters() which is often used in situations that may yield a key frame such as resizing the video. The semantic of that flag is the same as the RTCP FIR semantics from https://www.rfc-editor.org/rfc/rfc5104#section-3.5.1

index.html

dontcallmedom-bot · 2023-05-16T17:00:34Z

This issue had an associated resolution in WebRTC May 2023 meeting – 16 May 2023 (Issue #158 / PR #167: Requesting a key frame via setParameters):

RESOLUTION: refine PR #167 based on input during the call

dontcallmedom-bot · 2023-05-16T17:01:28Z

This issue was mentioned in WEBRTCWG-2023-05-16 (Page 24)

fippo · 2023-06-26T13:07:22Z

Current proposal (PR is not updated yet)

setParameters(RTCRtpSendParameters parameters,
	optional sequence<VideoEncoderEncodeOptions>
            encodeOptions);

with VideoEncoderEncodeOptions from WebCodecs

dontcallmedom-bot · 2023-06-28T06:34:28Z

This issue had an associated resolution in WebRTC June 2023 meeting – 27 June 2023 (Requesting keyframes via setParameters (WebRTC Extensions)):

RESOLUTION: use second parameter with a similar but different dictionary than WebCodecs, clarify promise doesn't wait for the keyframe to resolve

fippo · 2023-06-29T10:32:20Z

Updated, names are probably going to be subject to discussion.

@dontcallmedom: CI failure is

Error: ROR] Found tests in your spec, but missing [testSuiteURI](https://respec.org/docs/#testSuiteURI) in your ReSpec config.

which seems unrelated?

index.html

Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>

index.html

Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>

index.html

Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>

dontcallmedom · 2023-07-03T14:03:19Z

(I cannot reproduce the markup error locally; I suggest this can be merged, and I'll deal with the consequences if the error remains after merging)

index.html

…etParameters Both are defined as empty in order to allow webrtc-extensions to extend them which is done in w3c/webrtc-extensions#167

Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>

index.html

Co-authored-by: henbos <hbos@google.com>

index.html

Co-authored-by: henbos <hbos@google.com>

index.html

after the W3C changes in approach documented here: w3c/webrtc-extensions#167 chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/4643591 Note that this does not follow the route taken by the W3C API but still considers this flag a part of the encodingParameters. BUG=chromium:1354101 Change-Id: If0f0ec09bebddea1f01dd8afbe4747c21afe6793 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286741 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#40656}

Upstream commit: https://webrtc.googlesource.com/src/+/82c56ca7946181281c466343127f12c20727495a Request keyframe via setParameters after the W3C changes in approach documented here: w3c/webrtc-extensions#167 chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/4643591 Note that this does not follow the route taken by the W3C API but still considers this flag a part of the encodingParameters. BUG=chromium:1354101 Change-Id: If0f0ec09bebddea1f01dd8afbe4747c21afe6793 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286741 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#40656}

adding a new RTCSetParameterOptions object which has a sequence of RTCEncodingOptions similar to WebCodecs VideoEncoderEncodeOptions https://w3c.github.io/webcodecs/#dictdef-videoencoderencodeoptions and its keyFrame flag. On the native side, this adds the request_key_frame flag to the RtpEncodingParameters. WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/286741 Spec PRs: w3c/webrtc-pc#2885 w3c/webrtc-extensions#167 BUG=chromium:1354101 Change-Id: I5bfe266eac5990b1921212babdee1af35edc4242

adding a new RTCSetParameterOptions object which has a sequence of RTCEncodingOptions similar to WebCodecs VideoEncoderEncodeOptions https://w3c.github.io/webcodecs/#dictdef-videoencoderencodeoptions and its keyFrame flag. On the native side, this adds the request_key_frame flag to the RtpEncodingParameters. WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/286741 Spec PRs: w3c/webrtc-pc#2885 w3c/webrtc-extensions#167 Chromestatus feature: https://chromestatus.com/feature/5161082937409536 BUG=chromium:1354101 Change-Id: I5bfe266eac5990b1921212babdee1af35edc4242

adding a new RTCSetParameterOptions object which has a sequence of RTCEncodingOptions similar to WebCodecs VideoEncoderEncodeOptions https://w3c.github.io/webcodecs/#dictdef-videoencoderencodeoptions and its keyFrame flag. On the native side, this adds the request_key_frame flag to the RtpEncodingParameters. WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/286741 Spec PRs: w3c/webrtc-pc#2885 w3c/webrtc-extensions#167 Chromestatus feature: https://chromestatus.com/feature/5161082937409536 BUG=chromium:1354101 Change-Id: I5bfe266eac5990b1921212babdee1af35edc4242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4643591 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249577}

…r.setParameters, a=testonly Automatic update from web-platform-tests webrtc: add setParameterOptions to sender.setParameters adding a new RTCSetParameterOptions object which has a sequence of RTCEncodingOptions similar to WebCodecs VideoEncoderEncodeOptions https://w3c.github.io/webcodecs/#dictdef-videoencoderencodeoptions and its keyFrame flag. On the native side, this adds the request_key_frame flag to the RtpEncodingParameters. WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/286741 Spec PRs: w3c/webrtc-pc#2885 w3c/webrtc-extensions#167 Chromestatus feature: https://chromestatus.com/feature/5161082937409536 BUG=chromium:1354101 Change-Id: I5bfe266eac5990b1921212babdee1af35edc4242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4643591 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249577} -- wpt-commits: 3be83c4de8cafc13d4c00f3e9ddb07132a8a0705 wpt-pr: 43705

adding a new RTCSetParameterOptions object which has a sequence of RTCEncodingOptions similar to WebCodecs VideoEncoderEncodeOptions https://w3c.github.io/webcodecs/#dictdef-videoencoderencodeoptions and its keyFrame flag. On the native side, this adds the request_key_frame flag to the RtpEncodingParameters. WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/286741 Spec PRs: w3c/webrtc-pc#2885 w3c/webrtc-extensions#167 Chromestatus feature: https://chromestatus.com/feature/5161082937409536 BUG=chromium:1354101 Change-Id: I5bfe266eac5990b1921212babdee1af35edc4242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4643591 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249577}

Request keyframe via setParameters

cb36869

use setParameters() which is often used in situations that may yield a key frame such as resizing the video. The semantic of that flag is the same as the RTCP FIR semantics from https://www.rfc-editor.org/rfc/rfc5104#section-3.5.1

aboba assigned fippo May 14, 2023

aboba added the May 2023 Virtual Interim label May 14, 2023

respec.org FTW

44fe8da

fippo mentioned this pull request May 15, 2023

editorial: export RTCRtpTransceiver "transceiver kind" w3c/webrtc-pc#2872

Merged

fippo commented May 16, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

youennf added i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. Needs assignee input and removed i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. labels Jun 22, 2023

keyframe generation updates

677b584

dontcallmedom reviewed Jun 29, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

88535b1

Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>

dontcallmedom reviewed Jun 29, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Show resolved Hide resolved

fippo and others added 2 commits June 29, 2023 14:50

Update index.html

a2ea7f6

Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>

Update index.html

f39d0cb

Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>

fippo force-pushed the karl-friedrich-setparameters branch from ac996ed to f39d0cb Compare June 29, 2023 13:45

dontcallmedom reviewed Jul 3, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

2d82d17

Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>

aboba removed the Needs assignee input label Jul 6, 2023

jan-ivar requested changes Jul 6, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

fippo mentioned this pull request Jul 10, 2023

Add empty RTCSetParameterOptions dict as argument to setParameters w3c/webrtc-pc#2885

Merged

aboba and others added 2 commits July 27, 2023 07:35

Update index.html

3ad30b6

Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>

Update index.html

639b21a

henbos reviewed Jul 27, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

aboba and others added 2 commits July 27, 2023 07:39

Update index.html

9677393

Update index.html

b0a09d3

Co-authored-by: henbos <hbos@google.com>

henbos reviewed Jul 27, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

095eeeb

Co-authored-by: henbos <hbos@google.com>

henbos reviewed Jul 27, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

henbos reviewed Jul 27, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

henbos reviewed Jul 27, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

7ce6e53

henbos approved these changes Jul 27, 2023

View reviewed changes

aboba approved these changes Jul 27, 2023

View reviewed changes

aboba merged commit cbae391 into w3c:main Jul 27, 2023
1 of 2 checks passed

fippo deleted the karl-friedrich-setparameters branch July 27, 2023 14:43

fippo mentioned this pull request Jul 27, 2023

editorial: fix respec / validation woes #173

Merged

chromium-wpt-export-bot mentioned this pull request Dec 18, 2023

webrtc: add setParameterOptions to sender.setParameters web-platform-tests/wpt#43705

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Request keyframe via setParameters #167

Request keyframe via setParameters #167

fippo commented May 12, 2023 •

edited by pr-preview bot

dontcallmedom-bot commented May 16, 2023

dontcallmedom-bot commented May 16, 2023

fippo commented Jun 26, 2023

dontcallmedom-bot commented Jun 28, 2023

fippo commented Jun 29, 2023

dontcallmedom commented Jul 3, 2023

Request keyframe via setParameters #167

Request keyframe via setParameters #167

Conversation

fippo commented May 12, 2023 • edited by pr-preview bot

dontcallmedom-bot commented May 16, 2023

dontcallmedom-bot commented May 16, 2023

fippo commented Jun 26, 2023

dontcallmedom-bot commented Jun 28, 2023

fippo commented Jun 29, 2023

dontcallmedom commented Jul 3, 2023

fippo commented May 12, 2023 •

edited by pr-preview bot