Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(How) should we mitigate error code exploits? #70

Open
henbos opened this issue Feb 24, 2021 · 4 comments
Open

(How) should we mitigate error code exploits? #70

henbos opened this issue Feb 24, 2021 · 4 comments
Labels
security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response.

Comments

@henbos
Copy link
Collaborator

henbos commented Feb 24, 2021

As pointed out here, error codes that help distinguish between "wrong credentials" and generic network error might help an attacker for example brute-forcing credentials.

pc.onicecandidateerror is an example of this.

What should we do?

@henbos
Copy link
Collaborator Author

henbos commented Feb 24, 2021

CC @alvestrand who I believe already did some port filtering for similar problems

@juberti
Copy link

juberti commented Feb 27, 2021

Do we do this for 401 in fetch/XHR? Seems like it reduces debugging ability and may not be all that effective.

Generally, we should understand the threat model here before trying to come up with a solution.

@aboba
Copy link
Contributor

aboba commented Jun 17, 2021

Closing. We should reopen if we have a specific concern.

@aboba aboba closed this as completed Jun 17, 2021
@jan-ivar
Copy link
Member

I've made the subject more specific and reopened it.

@jan-ivar jan-ivar reopened this Jun 17, 2021
@dontcallmedom dontcallmedom added the security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response.
Projects
None yet
Development

No branches or pull requests

5 participants