New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect missing references on build #74
Conversation
Does this tool detect any issues with Web IDL? cc @youennf |
it detects the error that bikeshed detects, including webidl errors |
8dd39f7
to
e8de593
Compare
I don't think it would have caught #73 then, since detecting that kind of error requires knowing about all Web IDL in order to tell that something isn't defined. But maybe Bikeshed does detect this in the course of trying to link terms? |
bikeshed does detect it ,and minus the bug in the bot, the bot would have flagged this. (bikeshed doesn't use the data from webref yet, so it may have false positives in cases where its reference data is outdated) |
Fixed spec-prod issue. Re-run workflow to observe changes.. |
3bc036b
to
8b4f231
Compare
I've rebased, but the build still fails on the use of the undefined |
Sigh, I am updating to use Worker in #78 for now. |
Using spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_on Per #73 (comment)
8b4f231
to
f8e7806
Compare
Seems to pass, let's merge it. |
…ing references on buildUsing spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_onPer #73 (comment) Disambiguate autolink on resolve SHA: 0f203e1 Reason: push, by @youennf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Using spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_on
Per #73 (comment)
Preview | Diff