Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect missing references on build #74

Merged
merged 2 commits into from Mar 11, 2021
Merged

Detect missing references on build #74

merged 2 commits into from Mar 11, 2021

Conversation

dontcallmedom
Copy link
Member

@dontcallmedom dontcallmedom commented Mar 8, 2021

Using spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_on
Per #73 (comment)


Preview | Diff

@foolip
Copy link
Member

foolip commented Mar 8, 2021

Does this tool detect any issues with Web IDL?

cc @youennf

@dontcallmedom
Copy link
Member Author

it detects the error that bikeshed detects, including webidl errors

@foolip
Copy link
Member

foolip commented Mar 8, 2021

I don't think it would have caught #73 then, since detecting that kind of error requires knowing about all Web IDL in order to tell that something isn't defined. But maybe Bikeshed does detect this in the course of trying to link terms?

@dontcallmedom
Copy link
Member Author

bikeshed does detect it ,and minus the bug in the bot, the bot would have flagged this.

(bikeshed doesn't use the data from webref yet, so it may have false positives in cases where its reference data is outdated)

@sidvishnoi
Copy link
Member

Fixed spec-prod issue. Re-run workflow to observe changes..

@dontcallmedom dontcallmedom marked this pull request as ready for review March 8, 2021 12:52
@dontcallmedom
Copy link
Member Author

ready to merge once #73 & #75 have been merged

@youennf
Copy link
Collaborator

youennf commented Mar 11, 2021

ready to merge once #73 & #75 have been merged

They now landed

@dontcallmedom
Copy link
Member Author

I've rebased, but the build still fails on the use of the undefined DedicatedWorker - should that be DedicatedWorkerGlobalScope?

@youennf
Copy link
Collaborator

youennf commented Mar 11, 2021

I've rebased, but the build still fails on the use of the undefined DedicatedWorker - should that be DedicatedWorkerGlobalScope?

Sigh, I am updating to use Worker in #78 for now.
We should then have another PR to go back to DedicatedWorker.
Looking at XHR spec, this seems possible, maybe the issue is with the use of Global which is obviously wrong.

@youennf
Copy link
Collaborator

youennf commented Mar 11, 2021

Seems to pass, let's merge it.

@youennf youennf merged commit 0f203e1 into main Mar 11, 2021
github-actions bot added a commit that referenced this pull request Mar 11, 2021
…ing references on buildUsing spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_onPer #73 (comment) Disambiguate autolink on resolve

SHA: 0f203e1
Reason: push, by @youennf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants