-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lack of validation in RTCIceCandidate constructor #1165
Comments
I also filed #1166 |
If adding a note is enough then this is editorial. |
"There is also no place in the spec where these fields are being read, including addIceCandidate" is not an editorial issue. |
It struck me as odd that:
That is: both are nullable, but then...
|
That's a case where Web IDL syntax can't express the constraints, and so it's done in prose instead. If a single dictionary member is required, the required keyword is used, but if it's more complicated, then things end up looking like this... |
This is now fixed by #1229. |
There is no validation requirement for the arguments inside
RTCIceCandidate
constructor other than thatsdpMid
andsdpMLineIndex
must not be bothnull
. This seems to imply that the values inRTCIceCandidateInit
can be anything as long as they are of valid type.I suspect that the rationale for this is that the actual validation is only done when the candidate is passed to
addIceCandidate
. If so it is helpful to put a note in theRTCIceCandidate
constructor section.I also have difficulty understanding the use of the other fields in
RTCIceCandidate
that are not inRTCIceCandidateInit
. Since these fields are read only there doesn't seem to have way to set their values at all. There is also no place in the spec where these fields are being read, includingaddIceCandidate
.The text was updated successfully, but these errors were encountered: