Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are camelCase codec parameters useful at all? #1179

Closed
ibc opened this issue May 8, 2017 · 2 comments
Closed

Are camelCase codec parameters useful at all? #1179

ibc opened this issue May 8, 2017 · 2 comments

Comments

@ibc
Copy link

ibc commented May 8, 2017

Currently EDGE does not use camelCase RTP codec parameters (it uses packetization-mode rather than packetizationMode and so on). Also, there is no proper "conversion rule". In SDP land we have parameters such as sprop-maxcapturerate, useinbandfec and L that are mapped to spropMaxCaptureRate, useInbandFec and l forcing the implementation to keep a map of them (as here).

But, at the end, not even EDGE implements the ORTC camelCase syntax. Given that having a different naming provides zero benefit here, why not keep untouched the SDP naming?

@aboba
Copy link
Contributor

aboba commented May 8, 2017

@ibc Did you mean to file this bug against ORTC? Because WebRTC 1.0 keeps the SDP codec parameters in sdpFmtpLine, I don't think it has this problem, does it?

However, I do think there is an issue in ORTC. Since Edge implements both WebRTC 1.0 and ORTC, developers found it very confusing to convert SDP codec parameters back and forth from camelCase.

@ibc
Copy link
Author

ibc commented May 8, 2017

Opss sorry, indeed I wanted to report this issue in ORTC (wrong bookmark).

Proper issue in ORTC.

@ibc ibc closed this as completed May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants