-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getStats text still talks about selectors #1364
Comments
note that in some places using the word "selector" may still make sense such as
from the rtpsender.getStats description. |
@fippo I searched for the PR (see: https://github.com/w3c/webrtc-stats/pulls?page=4&q=is%3Apr+is%3Aclosed) but couldn't find what you're referring to. Here is the latest statistics "tip of tree': https://rawgit.com/w3c/webrtc-stats/master/webrtc-stats.html |
The final decision was to keep the selector and return the marching object (sender or receiver) ***Let selector be a RTCRtpSender or RTCRtpReceiver on connection which track member matches selectorArg. *** If no such sender or receiver exists, or if more than one sender or receiver fit this criteria, return a promise rejected with a newly created InvalidAccessError. |
@vr00m This currently reflected in the specification, right? Just trying to figure out if there is something to fix and if so, what. |
I think we're good (thankfully), I misinterpreted the lack of the word "selector" in -stats. |
wait, we might have an issue in the text @vr000m cites: |
the latest (unpublished) version of the webrtc-stats removed the selector concept (@vr000m can you point out the PR that did this?).
It is still in webrtc-pc, "selector" is mentioned 33 times :-(
The text was updated successfully, but these errors were encountered: