Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getStats text still talks about selectors #1364

Closed
fippo opened this issue Jun 9, 2017 · 7 comments
Closed

getStats text still talks about selectors #1364

fippo opened this issue Jun 9, 2017 · 7 comments
Labels

Comments

@fippo
Copy link
Contributor

fippo commented Jun 9, 2017

the latest (unpublished) version of the webrtc-stats removed the selector concept (@vr000m can you point out the PR that did this?).

It is still in webrtc-pc, "selector" is mentioned 33 times :-(

@fippo
Copy link
Contributor Author

fippo commented Jun 9, 2017

note that in some places using the word "selector" may still make sense such as

Gather the stats indicated by selector according to the stats selection algorithm.

from the rtpsender.getStats description.

@aboba
Copy link
Contributor

aboba commented Jun 12, 2017

@fippo I searched for the PR (see: https://github.com/w3c/webrtc-stats/pulls?page=4&q=is%3Apr+is%3Aclosed) but couldn't find what you're referring to.

Here is the latest statistics "tip of tree': https://rawgit.com/w3c/webrtc-stats/master/webrtc-stats.html

@vr000m
Copy link

vr000m commented Jun 12, 2017

The final decision was to keep the selector and return the marching object (sender or receiver)

***Let selector be a RTCRtpSender or RTCRtpReceiver on connection which track member matches selectorArg. ***

If no such sender or receiver exists, or if more than one sender or receiver fit this criteria, return a promise rejected with a newly created InvalidAccessError.

@aboba
Copy link
Contributor

aboba commented Jun 12, 2017

@vr00m This currently reflected in the specification, right? Just trying to figure out if there is something to fix and if so, what.

@aboba aboba added the question label Jun 12, 2017
@fippo
Copy link
Contributor Author

fippo commented Jun 12, 2017

I think we're good (thankfully), I misinterpreted the lack of the word "selector" in -stats.

@fippo fippo closed this as completed Jun 12, 2017
@fippo
Copy link
Contributor Author

fippo commented Jun 12, 2017

wait, we might have an issue in the text @vr000m cites:
http://w3c.github.io/webrtc-pc/#rtcpeerconnection-interface-extensions-2
That step (4) does not seem to cover the case that selector is null.

@aboba
Copy link
Contributor

aboba commented Jun 12, 2017

@fippo Opened new issue: #1374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants