Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data channel receive procedure missing? #1825

Closed
lgrahl opened this issue Apr 2, 2018 · 2 comments · Fixed by #1849
Closed

Data channel receive procedure missing? #1825

lgrahl opened this issue Apr 2, 2018 · 2 comments · Fixed by #1849
Assignees
Labels
Needs PR Discussion has converged - Pull Request needed

Comments

@lgrahl
Copy link
Contributor

lgrahl commented Apr 2, 2018

It seems there is no data channel receive procedure that can be followed, e.g. nothing tells us when a message event is invoked and what validation steps are required (check for open [or closing], ...).

The WPT tests reference this WS spec section (When a WebSocket message has been received [...]) and I would propose to copy that.

@lgrahl
Copy link
Contributor Author

lgrahl commented Apr 8, 2018

We should discuss whether messages can still be received by the peer who initiates the closing procedure or not (see this discussion beginning at comment 55).

@aboba
Copy link
Contributor

aboba commented Apr 19, 2018

@lgrahl Agree that the closing procedure doesn't provide enough detail. As discussed in Issue 559394, when a peer calls close() (resulting in readyState transitioning to "closing") more messages can't be sent, but data can still be received until readyState becomes "closed".

@aboba aboba added the Needs PR Discussion has converged - Pull Request needed label Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs PR Discussion has converged - Pull Request needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants