New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be explicit about no ICE event on close #2336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
approved these changes
Oct 21, 2019
jan-ivar
approved these changes
Oct 21, 2019
jianjunz
added a commit
to jianjunz/web-platform-tests
that referenced
this pull request
Oct 24, 2019
This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336.
jianjunz
added a commit
to jianjunz/web-platform-tests
that referenced
this pull request
Oct 24, 2019
This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336.
jianjunz
added a commit
to jianjunz/web-platform-tests
that referenced
this pull request
Oct 24, 2019
This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336.
henbos
approved these changes
Oct 24, 2019
jianjunz
added a commit
to jianjunz/web-platform-tests
that referenced
this pull request
Oct 25, 2019
This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336.
jianjunz
added a commit
to jianjunz/web-platform-tests
that referenced
this pull request
Nov 8, 2019
This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336.
henbos
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 8, 2019
…nt. (#19861) This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 29, 2019
… iceconnectionstatechange event., a=testonly Automatic update from web-platform-tests Closing a PeerConnection should not fire iceconnectionstatechange event. (#19861) This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336. -- wpt-commits: 2d737f55bdc93c162a95a56f71745f00a38c8c83 wpt-pr: 19861
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 29, 2019
… iceconnectionstatechange event., a=testonly Automatic update from web-platform-tests Closing a PeerConnection should not fire iceconnectionstatechange event. (#19861) This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336. -- wpt-commits: 2d737f55bdc93c162a95a56f71745f00a38c8c83 wpt-pr: 19861
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2019
… iceconnectionstatechange event., a=testonly Automatic update from web-platform-tests Closing a PeerConnection should not fire iceconnectionstatechange event. (#19861) This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336. -- wpt-commits: 2d737f55bdc93c162a95a56f71745f00a38c8c83 wpt-pr: 19861 UltraBlame original commit: 29c27e78eb6da26c63daf91f7f6ddd6d1ead4f13
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2019
… iceconnectionstatechange event., a=testonly Automatic update from web-platform-tests Closing a PeerConnection should not fire iceconnectionstatechange event. (#19861) This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336. -- wpt-commits: 2d737f55bdc93c162a95a56f71745f00a38c8c83 wpt-pr: 19861 UltraBlame original commit: 29c27e78eb6da26c63daf91f7f6ddd6d1ead4f13
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2019
… iceconnectionstatechange event., a=testonly Automatic update from web-platform-tests Closing a PeerConnection should not fire iceconnectionstatechange event. (#19861) This is a test case for w3c/webrtc-pc#2335 and w3c/webrtc-pc#2336. -- wpt-commits: 2d737f55bdc93c162a95a56f71745f00a38c8c83 wpt-pr: 19861 UltraBlame original commit: 29c27e78eb6da26c63daf91f7f6ddd6d1ead4f13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2335
Preview | Diff