Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of duplicate rids in sRD seems underspecified #2780

Closed
docfaraday opened this issue Oct 6, 2022 · 4 comments · Fixed by #2800
Closed

Handling of duplicate rids in sRD seems underspecified #2780

docfaraday opened this issue Oct 6, 2022 · 4 comments · Fixed by #2800
Assignees

Comments

@docfaraday
Copy link
Contributor

For example, a=simulcast:recv foo;foo

While this is pretty silly, I don't see anything in RFC 8853 that forbids it. I see two reasonable options:

  1. Ignore any duplicates.
  2. Fail the sRD, probably with an InvalidAccessError.

I think I prefer option 1. We might want to consider consistency with #2769

@jan-ivar
Copy link
Member

jan-ivar commented Oct 7, 2022

Ignore any duplicates.

Do you mean A) ignore the second foo, or B) ignore both foos?

@docfaraday
Copy link
Contributor Author

I mean A.

@jan-ivar
Copy link
Member

It seems simple enough to mandate that an answer ignore duplicates in an offer.

@dontcallmedom-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants