Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express RTCPeerConnectionState values using [[IceConnectionState]], and reduce complexity #2828

Merged
merged 2 commits into from Mar 23, 2023

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Feb 13, 2023

Fixes #2827.

Since this depends on #2826, a nicer Preview.


Preview | Diff

@jan-ivar jan-ivar self-assigned this Feb 13, 2023
@alvestrand
Copy link
Contributor

This is OK on implementors (easy to code), but hard on users to understand.
Suggest adding an explanatory note about ConnectionState:Connecting, something like:

The state "connecting" means, colloquially, that the connection is not usable at the moment, but it may become usable without any intervention by the user. This refers, for instance, to the state when an ICE connection is in "disconnected" due to a temporary failure, as well as the state when the ICE connection's handshake isn't finished yet.

@jan-ivar
Copy link
Member Author

I added back the technically descriptive note for now.

The state "connecting" means, colloquially, that the connection is not usable at the moment,

I don't think we can say that in general about this aggregate state. E.g. a usable connection may drop to "connecting" if a transport is added, without making the existing connection unusable.

Some of the other language about transient-ness sounded nice, if we can word it differently. Happy to iterate here.

@jan-ivar jan-ivar changed the title Express RTCPeerConnectionState values using [[IceConnectionState]], and fix state gap Express RTCPeerConnectionState values using [[IceConnectionState]], and reduce complexity Feb 18, 2023
@jan-ivar jan-ivar merged commit 4ba0a0d into w3c:main Mar 23, 2023
2 of 3 checks passed
@dontcallmedom-bot
Copy link

dontcallmedom-bot commented Mar 29, 2023

@dontcallmedom-bot
Copy link

This issue was mentioned in WEBRTCWG-2023-02-21 (Page 30)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard to tell if there are state gaps in connectionState algorithm
5 participants