New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial mistakes in iceServers limit #2889

Closed

jan-ivar opened this issue Aug 15, 2023 · 0 comments · Fixed by #2890

Assignees

Member

jan-ivar commented Aug 15, 2023

While we added an iceServers limit in #2679, some editorial mistakes makes it not work:

A later merge mistake in Fix setConfiguration default value handling to match implementations. #2691 (my bad) erased the truncation in setConfiguration
A typo in the constructor fails to truncate anything: "If configuration.iceServer is an array truncate it to the maximum number of supported elements." It should be s/iceServer/iceServers/

The text was updated successfully, but these errors were encountered:

jan-ivar self-assigned this

jan-ivar mentioned this issue

Move iceServers limit to setConfiguration steps. #2890

Merged

alvestrand closed this as completed in #2890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment