-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addTrack's streams parameter is unused. #369
Comments
This applies to addTransceiver as well btw. It would be nice if the overall intent of this parameter was described. Also: Is the parameter optional? I think the answers are yes and no respectively, because users can do this:
or even this:
where So I think I'm good, but this could be a lot clearer. |
Sorry, this was resolved in #288 (it is), but the remaining question stands (validation), and I hope we agree that processing models should explain to implementers exactly what to do with input parameters. |
Copying over comment from #426: The expected result is that there are MSIDs for those streams listed in the SDP. This will probably take a JSEP reference (not sure where). |
I agree with @jan-ivar that this processing model needs to be detailed out. The addTrack() steps don't say much about how the track should be used either. Just that it's set on the sender object. This section needs some work. We should be able to define some steps that can be shared between addTrack() and addTransceiver(). |
Proposed fix: PR #702 |
We must either specify how this parameter is to be used, or remove it.
The text was updated successfully, but these errors were encountered: