Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unreliability (with parameters dictionary) #76

Merged
merged 3 commits into from
Nov 14, 2018

Conversation

pthatcherg
Copy link
Collaborator

Via a dictionary with RTCQuicStreamParameters.reliable passed to createSendStream.

@aboba
Copy link
Collaborator

aboba commented Nov 7, 2018

@pthatcherg Personally, I like this approach better, because there may be other parameters needed in future.

Copy link
Collaborator

@aboba aboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sent unreliably" should probably be changed to "sent with no retransmissions".

@aboba
Copy link
Collaborator

aboba commented Nov 7, 2018

@pthatcherg Also, there is various text in the document that indicates that only reliable streams are supported. So that text also needs to be updated.

@pthatcherg
Copy link
Collaborator Author

Notes to self:

  1. Go with parameter to approach (close Add support for unreliability (with an attribute) #74)

  2. Consider calling it "disableRetransmissions"

  3. Add an example and a paragraph about how this intended to be used (with many small unidirectional streams).

@pthatcherg
Copy link
Collaborator Author

OK, I renamed it, removed the "we don't do unreliable" text in other places, and added an example.

@aboba aboba merged commit 1dfee24 into master Nov 14, 2018
@pthatcherg pthatcherg deleted the unreliable2 branch February 20, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants