Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is ssrc a DOMString? #105

Closed
taylor-b opened this issue Dec 15, 2016 · 4 comments
Closed

Why is ssrc a DOMString? #105

taylor-b opened this issue Dec 15, 2016 · 4 comments
Assignees

Comments

@taylor-b
Copy link
Contributor

Every instance of ssrc in webrtc is an unsigned long. Is there a reason for it to be a DOMString in webrtc-stats? If so, a brief explanation would be helpful, with a description of what non-numeric values can be expected.

@jesup
Copy link

jesup commented Dec 15, 2016

SSRCs by definition in RTP are 32-bit unsigned values. While you could translate them into hex (upper or lower? What if people compare against SDP, and the case is different? etc), that's kinda silly.

They should be 32 bits, unsigned.

@alvestrand
Copy link
Contributor

We should convert it in the spec to 32 bit unsigned integers.

@alvestrand
Copy link
Contributor

All the comments seem to indicate consensus here.

@alvestrand
Copy link
Contributor

Changed to unsigned int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants