Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is ssrc a DOMString? #105

Closed
taylor-b opened this issue Dec 15, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@taylor-b
Copy link
Contributor

commented Dec 15, 2016

Every instance of ssrc in webrtc is an unsigned long. Is there a reason for it to be a DOMString in webrtc-stats? If so, a brief explanation would be helpful, with a description of what non-numeric values can be expected.

@jesup

This comment has been minimized.

Copy link

commented Dec 15, 2016

SSRCs by definition in RTP are 32-bit unsigned values. While you could translate them into hex (upper or lower? What if people compare against SDP, and the case is different? etc), that's kinda silly.

They should be 32 bits, unsigned.

@alvestrand

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2017

We should convert it in the spec to 32 bit unsigned integers.

@alvestrand

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2017

All the comments seem to indicate consensus here.

@alvestrand

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2017

Changed to unsigned int.

@alvestrand alvestrand closed this Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.