Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should document what RTCRTPStreamStats metrics are valid when isRemote is true. #108

Closed
taylor-b opened this issue Dec 15, 2016 · 3 comments
Assignees

Comments

@taylor-b
Copy link
Contributor

For example:

  • targetBitrate isn't something that's communicated via RTCP (to my knowledge), so I imagine it's only valid when isRemote is false.
  • roundTripTime, though it uses RTCP RRs for its calculation, is a property of sent streams and thus only valid when isRemote is false.

Also: it would be helpful to have a small summary of how RTCOutboundRTPStreamStats, RTCInboundRTPStreamStats, isRemote and associateStatsId relate to each other. As I understand, each sent stream will provide an RTCOutboundRTPStreamStats where isRemote is false and an RTCInboundRTPStreamStats where isRemote is true. And each received stream will provide an RTCInboundRTPStreamStats where isRemote is false, and an RTCOutboundRTPStreamStats where isRemote is true. Which makes me realize: why do we have separate inbound/outbound stats objects that are associated by ID, instead of just putting everything in one object?

@alvestrand
Copy link
Contributor

The reason why the local sender & remote receiver aren't bundled into one object is that the timestamps will be different (one is from local variables, the other is from the RTCP report reception).

@vr000m
Copy link
Contributor

vr000m commented May 10, 2017

I believe the changes in #191 fixes this? @jan-ivar @taylor-b WDYT?

@taylor-b
Copy link
Contributor Author

Agreed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants