Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a "how to add more stats" guideline document #345

Closed
alvestrand opened this issue Apr 4, 2018 · 9 comments
Closed

Write a "how to add more stats" guideline document #345

alvestrand opened this issue Apr 4, 2018 · 9 comments
Assignees

Comments

@alvestrand
Copy link
Contributor

This has been on the plan for a while, but it's nice to have a bug on it.

@henbos
Copy link
Collaborator

henbos commented Apr 4, 2018

This document will be targeted towards developers and aims to:

  • Give developers an idea how standardization works and guide them through it.
  • Put ownership of the entire process of adding the stats (spec issue, spec PR, implementation) on the developer proposing the stats. Allowing resources and expertise to be used appropriately.
  • Decrease the perceived and actual delay time of standardization efforts. Spec should not be a blocker unless we really should not add the stats.

No more "I filed an issue and nothing happened so I added a goog-stat".

This will allow us to:

  • BAN adding more goog-stats, which will...
  • Incentivize more development efforts to be put into spec-compliance, and
  • Encourage switching to the spec-compliant API.
  • And eventually deprecate legacy getStats().

@henbos
Copy link
Collaborator

henbos commented Apr 4, 2018

The document should also cover experimental stats, both the kind we aim to standardize but need to test the metric before we know it's a good one and the kind that is only useful for Chromium debugging and evaluating the result of feature experiments.

@henbos
Copy link
Collaborator

henbos commented Apr 4, 2018

Experimental stats will have limited exposure, e.g. not exposed to the web platform by default (hidden behind Origin Trials experiment, etc.).

@henbos
Copy link
Collaborator

henbos commented May 2, 2018

Here's the doc I intend to share, please comment.
https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing
I'll send it to the mailing list tomorrow. @vr000m this also shows an overview of some of the C++ implementation of getStats() even if it doesn't tell you how difficult it is to add a particular metric.

@alvestrand
Copy link
Contributor Author

Sent to mailing list, no comments. Guess it's perfect.

@alvestrand
Copy link
Contributor Author

It makes sense to either link to it or copy it into the webrtc-stats repo - not as a spec, but as "helpful material".

@henbos
Copy link
Collaborator

henbos commented May 16, 2018

I'll create a PR to link to it from our README.md.

@henbos
Copy link
Collaborator

henbos commented Oct 18, 2022

We're so closed to PR we probably don't need this anymore

@henbos henbos closed this as completed Oct 18, 2022
@vr000m
Copy link
Contributor

vr000m commented Oct 18, 2022

Go to provisional stats to give input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants