Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nackCount to nacksReceived & nacksSent respectively? #390

Closed
jan-ivar opened this issue Feb 13, 2019 · 1 comment
Closed

Rename nackCount to nacksReceived & nacksSent respectively? #390

jan-ivar opened this issue Feb 13, 2019 · 1 comment

Comments

@jan-ivar
Copy link
Member

From @vr000m in #384 (review):

When it was in the base class, the ambigious *Count name made sense because the text described how the counters were updated at the sender and receiver. Now that these metrics are being moved to the appropriate dictionary, we can add the suffix -Sent/-Received qualifier.

If we are going down this path, I would encourage the -suffix, but that would require retiring the -Count metrics.

Browsers that have implemented these -Count metrics should also chime in? @henbos @aboba @jan-ivar @youennf

I don't actually think we can afford this at this point due to web compat, but I'm breaking this out as a separate issue, for discussion.

@alvestrand
Copy link
Contributor

Closing this one as "won't do because it's implemented with the old name".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants