Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to describe the relationship of codec and fec mechanisms #610

Open
fippo opened this issue Aug 18, 2021 · 5 comments
Open

how to describe the relationship of codec and fec mechanisms #610

fippo opened this issue Aug 18, 2021 · 5 comments

Comments

@fippo
Copy link
Contributor

fippo commented Aug 18, 2021

when using chrome to make a call on
https://webrtc.github.io/samples/src/content/peerconnection/constraints/
the inbound-rtp codecId stat is pointing to RTCCodec_1_Inbound_96 which resolves to VP8.
However, Chrome actually wraps this in RED (historically, see https://bugs.chromium.org/p/webrtc/issues/detail?id=1467)
But this is impossible to detect using stats.

What is the proper way to deal with this? Should the codecId point to video/RED which then has an underlying codecId?

@vr000m
Copy link
Contributor

vr000m commented Aug 18, 2021

What's in the SDP?

@fippo
Copy link
Contributor Author

fippo commented Aug 18, 2021

abbreviated:

m=video 9 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 102 121 127 120 125 107 108 109 35 36 124 119 123
a=rtpmap:96 VP8/90000
a=rtpmap:124 red/90000
a=rtpmap:119 rtx/90000
a=fmtp:119 apt=124
a=rtpmap:123 ulpfec/90000

payload type on the wire is 124

@vr000m
Copy link
Contributor

vr000m commented Aug 22, 2021

What is happening in stats? curious about what is being reported on the payloadType and mimeType?

The endpoint is receiving PT 124 but the stats are reporting that PT is 96?

@alvestrand
Copy link
Contributor

I don't see any association between 96 and 124 in the SDP. Is that just "declared by being in the packet"?

@fippo
Copy link
Contributor Author

fippo commented Feb 23, 2022

@alvestrand this isn't done "properly" in chrome's SDP at all (see question on the decade old bug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants