Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sender-side packetsReceived can be negative from garbage RRs #772

Open
jan-ivar opened this issue Nov 7, 2023 · 1 comment
Open

Sender-side packetsReceived can be negative from garbage RRs #772

jan-ivar opened this issue Nov 7, 2023 · 1 comment

Comments

@jan-ivar
Copy link
Member

jan-ivar commented Nov 7, 2023

Sender-side packetsReceived is unsigned, yet is a result of a subtraction of two RR values that could be garbage:

image

Having stats reflect garbage input seems helpful for debugging, but it's unspecified what value user agents should report if the result of the subtraction is negative. Changing it to signed seems simplest, and would match packetsLost.

This came up in bug 1853717 which (ended up being a bug in Firefox instead but) raised how to handle garbage RRs from a server.

@henbos
Copy link
Collaborator

henbos commented Nov 8, 2023

Having it be signed instead makes sense to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants