Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should RTCRtptransceiver.stop() cause inbound-rtp stats to disappear? #784

Open
jan-ivar opened this issue Feb 26, 2024 · 0 comments
Open

Comments

@jan-ivar
Copy link
Member

jan-ivar commented Feb 26, 2024

This language on RTP stats seems to go against #26: "RTP monitored objects are deleted when the corresponding RTP sender or RTP receiver is reconfigured to remove the corresponding RTP stream. This happens for the old SSRC when the ssrc changes, a simulcast layer is dropped or the RTCRtpTransceiver's currentDirection becomes "stopped"".

The "receiver is reconfigured" part seems fine, and probably describes intent, that things stick around until replaced.

But this part: "This happens ... when ...the RTCRtpTransceiver's currentDirection becomes "stopped"" ends up meaning stats are deleted on pc.close (which will stop the RTCRtpTransceiver, causing currentDirection to "return "stopped"").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant