Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wt.ready and wt.closed trigger unhandled rejections #601

Closed
jan-ivar opened this issue May 8, 2024 · 0 comments · Fixed by #602
Closed

wt.ready and wt.closed trigger unhandled rejections #601

jan-ivar opened this issue May 8, 2024 · 0 comments · Fixed by #602
Assignees
@jan-ivar
Labels
Ready for PR

Comments

@jan-ivar
Copy link
Member

jan-ivar commented May 8, 2024

The wt.closed and wt.ready promises are rejected on connection failure, which seems fine (similar to stream spec's reader.closed).

However, unlike reader.closed we don't set promise.[[PromiseIsHandled]].

As discovered in #539 (comment) this makes it hard for a JS library to polyfill a wt.state attribute without side-effects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-ivar jan-ivar

Labels
Ready for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set [[PromiseIsHandled]] on wt.ready and wt.closed. jan-ivar/webtransport
2 participants
@wilaw @jan-ivar