-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine definition of Discoverer #738
Comments
I would prefer the above-proposed definition, maybe adding the Introduction and Exploration type would be good, so something like:
I think we should simply link to the discovery chapter as well. I would also prefer the Discovery Agent or Discovery Consumer, with a slight preference for the latter since Discovery Agent can be thought of as the service running in the Thing for the introduction mechanisms. The word Discoverer is also not easy to pronounce (or not pleasing to pronounce), but that might be related to English not being my mother tongue. |
This is a good proposal that relates to #673 |
I would prefer if the definition of "Discoverer" covered only a client searching for TDs and not registering TDs (although technically both actions use different parts of the same API in TDDs). I have added two definitions, as follows, in the PR I will shortly commit:
I moved the "e.g." in the definition of "Discoverer" AFTER the "discover and fetch a Thing Description" since that is the definition, not an example; being introduced to and fetching a TD from a Directory is one way to do this, so those are examples. We don't currently use the term "Registrant" in the WoT Discovery document but I'm going to work on that next, addressing this and several other issues that Ben noted recently in wot-discovery issue #299 |
BTW note both "discoverer" and "registrant" are actual English words with definitions aligned with these definitions:
|
TIL that "discoverer" is a word. English is weird 😆 |
I've noticed that the definition of "Discoverer" in WoT Architecture 1.1 is inconsistent with the way the term is used in the WoT Discovery 1.1 specification.
WoT Architecture section 3 defines a "Discoverer" as:
WoT Discovery section 5 says:
The definition in WoT Architecture only seems to cover the registration of TDs with an exploration service (a role perhaps more accurately described as a "registrant"), whereas section 3 of WoT Discovery goes on to describe many other functions such as:
A more accurate definition might therefore be:
"An entity which acts as a consumer of a WoT Discovery service, e.g. to discover and fetch a Thing Description, search a Thing Description Directory or register a Thing Description with a Thing Description Directory."
While I'm on this topic, I know there has been a lot of discussion around this already but I still think the term "Discoverer" (apart from not being a real word in the English language) is a confusing term for an entity which also registers a TD. A potential alternative term could be "Discovery Agent" (or "Discovery Client", "Discovery Consumer).
The text was updated successfully, but these errors were encountered: