Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cov:block2SZX to cov:block2Size #256

Closed
ektrah opened this issue Mar 8, 2023 · 5 comments · Fixed by #259
Closed

Rename cov:block2SZX to cov:block2Size #256

ektrah opened this issue Mar 8, 2023 · 5 comments · Fixed by #259
Labels
coap related to coap protocol binding

Comments

@ektrah
Copy link
Member

ektrah commented Mar 8, 2023

We should rename cov:block2SZX and cov:block1SZX to cov:block2Size and cov:block1SZX, respectively, as the SZX field actually contains the encoding of the size (0, 1, 2, ...) and not the size itself (16, 32, 64, ...).

@ektrah ektrah added the coap related to coap protocol binding label Mar 8, 2023
@JKRhb
Copy link
Member

JKRhb commented Mar 8, 2023

Took the freedom of opening #259 as fix for this issue, and also already incorporated the changes into #246.

@ektrah
Copy link
Member Author

ektrah commented Mar 8, 2023

You're fast! 😃

Thanks!

@ektrah
Copy link
Member Author

ektrah commented Mar 8, 2023

Or maybe blockSize2 and blockSize1?

@JKRhb
Copy link
Member

JKRhb commented Mar 14, 2023

Or maybe blockSize2 and blockSize1?

I think I would tend to keep it as block2Size/block1Size (to make the Block2/Block1 association a bit more explicit), but I don't feel strongly about it. If you prefer blockSize2/blockSize1, we can also use that :)

@egekorkan
Copy link
Contributor

Or maybe blockSize2 and blockSize1?

@ektrah we are going to merge #259 since you have approved it. If you prefer the other notation, we can reopen this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coap related to coap protocol binding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants