Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ConsumedThing inheritance in ExposedThing #281

Closed
zolkis opened this issue Nov 6, 2020 · 2 comments
Closed

Remove ConsumedThing inheritance in ExposedThing #281

zolkis opened this issue Nov 6, 2020 · 2 comments

Comments

@zolkis
Copy link
Contributor

zolkis commented Nov 6, 2020

and clarify the "local client" optimizations in ExposedThing.

Coming from eclipse-thingweb/node-wot#333

One solution would be to resolve expose() with a ConsumedThing with local bindings (for maintaining convenience), instead of ExposedThing extending ConsumedThing, which created confusions.
@danielpeintner
Copy link
Contributor

It looks like we do have consensus for point 1. and 2. proposed here

Let's settle this discussion (and our thoughts) a bit more and go for it if no more concerns pop up

@zolkis
Copy link
Contributor Author

zolkis commented Nov 23, 2020

Fixed by #280

@zolkis zolkis closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zolkis @danielpeintner