Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing keywords for "in" property in "APIKeySecurityScheme" #1557

Closed
FadySalama opened this issue Jun 29, 2022 · 2 comments · Fixed by #1561
Closed

Missing keywords for "in" property in "APIKeySecurityScheme" #1557

FadySalama opened this issue Jun 29, 2022 · 2 comments · Fixed by #1561
Assignees

Comments

@FadySalama
Copy link
Contributor

"in": {
"type": "string",
"enum": [
"header",
"query",
"body",
"cookie"
]

The APIKeySecurityScheme is missing the keywords uri and auto for the in property. (See: here)

@github-actions github-actions bot added the needs-triage Automatically added to new issues. TF should triage them with proper labels label Jun 29, 2022
@sebastiankb sebastiankb removed the needs-triage Automatically added to new issues. TF should triage them with proper labels label Jun 29, 2022
@sebastiankb
Copy link
Contributor

from today's TD call:

  • Security TF will evaluate if all keywords make sense in this context (it will be evaluate if auto does make sense here or not)
  • @egekorkan please update the JSON Schema and provide an PR, the Security TF will review the PR

@mmccool
Copy link
Contributor

mmccool commented Jul 6, 2022

Security TF reviewed the PR and it is ok, please proceed with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants