-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate running TD rendering script #883
Comments
Also as you mentioned, |
I use cygwin to run GitHub provides a function called "GitHub Actions" for CI/CD. |
During March 6th TD telecon, @danielpeintner mentioned he can look into the feasibility. |
what is the status here? |
I can try to setup a GitHub action as mentioned here. Maybe we do that after FPWD. I see 2 issue:
@ashimura I wonder whether there are other W3C repos doing something similar? |
It would be good to know what kind of GitHub payment plan the W3C has since our builds will consume minutes that are shared by the entire W3C organization in GitHub. See https://github.com/pricing |
is this something what we can simple do as GitHub Actions? |
I think both can work, Travis and GitHub actions. I noticed that the render script causes some noise after each run (e.g., always updating SVG images etc). Not sure what we could do about that. If I work on a PR without changing SVG details I simply don't commit those changes. A script can not do so but that might be a non-issue... |
@JKRhb I recall you mentioned that you want to work on automating the render process. Is this correct? I do not find any issue / mentioning anywhere. Thanks for any feedback! |
I think we discussed this in the last TD call, but arrived at the conclusion that we wanted to use a pre-commit hook instead? I think @relu91 wanted to create a PR for that. |
#1549 adds husky pre-commit for rendering but does not fully solve this issue (rendering is done locally). Having said that, it will definitely help to reduce issues in may cases... |
I propose to close this issue since for TD2.0 we should re-design the spec generation |
from today's TD call, decided to close this issue |
Changes to the TD document require to run
npm run render
or
./render.sh
locally to get the generated
index.html
.I wonder whether it makes sense to automate this process based on each commit.
Do we want to investigate how to do that or are there any reasons why we did not do that in the first place?
The text was updated successfully, but these errors were encountered: