Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the serialization interface between bls and zexe #23

Closed
drskalman opened this issue Dec 4, 2020 · 2 comments
Closed

fix the serialization interface between bls and zexe #23

drskalman opened this issue Dec 4, 2020 · 2 comments
Assignees

Comments

@drskalman
Copy link
Collaborator

zexe now uses serde like serialization as zkcrypto was using a EncodedPoint trait. We need to either adapt or migrate to new serialization or the tests won't pass.

@drskalman
Copy link
Collaborator Author

I spent the first part of the week to implement an adapter so I can keep @burdges 's macros intact. Then on @burdges 's advice I reimplemented the macro using the new interface. Note that we couldn't derive Canonical(De)Serialize on Signature and PublicKey because ProjectiveCurve does not implement those traits.

@drskalman drskalman self-assigned this Dec 4, 2020
@drskalman drskalman added the sync label Dec 4, 2020
@drskalman
Copy link
Collaborator Author

Moved zbls macros to new serialization paradaigm. Now the tests also compile but two fails: da4ce55,

running 4 tests
test single::tests::single_messages ... FAILED
test delinear::tests::delinearized ... ok
test distinct::tests::distinct_messages ... ok
test bit::tests::proofs_of_possession ... FAILED

Will investigate in aother issue.

@drskalman drskalman removed the sync label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant